Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/dc 3170 redis connect error #147

Merged
merged 4 commits into from
Jan 7, 2025
Merged

Fix/dc 3170 redis connect error #147

merged 4 commits into from
Jan 7, 2025

Conversation

jennyc06
Copy link
Contributor

@jennyc06 jennyc06 commented Dec 31, 2024 •
edited
Loading

  • Add config to immediately throw & stop app when failed to connect to dependencies / prepare app
  • Add log when redis reconnecting / reconnected for debugging
  • Add maxRetryDelayMs config for redis

travis-shoplineapp
travis-shoplineapp approved these changes Jan 2, 2025
View reviewed changes
lib/models/App.js Outdated
return this
} catch (err) {
console.error('error when starting app', err);
if (this.config && this.config.app && this.config.app.throwAndStopWhenError) {
Copy link
Contributor

@travis-shoplineapp travis-shoplineapp Jan 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be a fix rather than needing backward compatibility, a service should not start if the dependency fail
also when a client chooses to upgrade sl-express, they should be aware our change
consider reducing code complexity

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@travis-shoplineapp travis-shoplineapp merged commit bdc792e into master Jan 7, 2025
@jennyc06 jennyc06 mentioned this pull request Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maryShopline1 maryShopline1 maryShopline1 approved these changes

@slbosco slbosco slbosco approved these changes

@travis-shoplineapp travis-shoplineapp travis-shoplineapp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jennyc06 @travis-shoplineapp @slbosco @maryShopline1